Conversation
linglingye001
force-pushed
the
linglingye/failover
branch
from
25a9a9d to
12a6ec4
Compare
linglingye001
force-pushed
the
linglingye/failover
branch
from
851d59f to
507beac
Compare
Eskibear
reviewed
Oct 21, 2024
Member
|
How about seperating this PR into two smaller PR to make it easier to review. For example, the change of adding client manager can be a seperated PR and I can approve it quickly. And with client manager change merged, it won't block the following new feature like snapshot support. |
linglingye001
force-pushed
the
linglingye/failover
branch
from
32bf44b to
3d95750
Compare
linglingye001
force-pushed
the
linglingye/failover
branch
from
3b563d8 to
1ea1d51
Compare
|
|
||
| function isFailoverableError(error: any): boolean { | ||
| // ENOTFOUND: DNS lookup failed, ENOENT: no such file or directory | ||
| return isRestError(error) && (error.code === "ENOTFOUND" || error.code === "ENOENT" || |
Member
There was a problem hiding this comment.
https://nodejs.org/api/errors.html#common-system-errors Missed some error type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replica Auto-Discovery: For App Configuration stores with geo-replication enabled, the provider will now automatically discover any additional replicas and attempt to connect to them when it fails to connect to user-provided endpoints in code. This capability allows applications to leverage geo-replication for enhanced resiliency without code change and redeployment. Replica discovery is enabled by default and can be disabled by setting the new AzureAppConfigurationOptions.replicaDiscoveryEnabled property equal to false.
Usage:
Note:
Replica discovery can only work in node.js environment.